Few color picker changes to propose - #11616

Can we get an Arcade upload target to try out the new blocks?

ah the arcade side of pr had em, here's a build with a very simple project https://arcade.makecode.com/app/590bd0d230b87b393be2ea5905452f455f73966f-ef652ebaad#pub:S43701-26279-46872-67107

Switching back and forth between blocks/javascript/blocks again causes the square to just display a black block:

If you use a variable to store the color, then switch to javascript and make any change (such as addding a comment), when you switch back to blocks and remove the variable, the background of the color picker will now be brown:

fix for decomp (it was reading values that were replaced later in decompilation pass) https://arcade.makecode.com/app/d151c4577c684b9c7a93cfb1fa84c770dc21ab6a-310979b002

It's no longer brown, but now you get this instead:

ah i see i'm dumb, i saw a different minor issue in screenshot and misread it as that -- fix 2.0 https://arcade.makecode.com/app/384d26ca1019facdcb6c58fdd8d4071150a1654a-6d485d983c (will have to make a new block for it b/c old one got swapped in too far)

Okay, let me know when the new block has been pulled through. Still seeing it in the recent build:

Okay, let me know when the new block has been pulled through. Still seeing it in the recent build:

Ah meant new blocks as in from toolbox, the old one compiled to a function it shouldn't have basically so the project javascript itself wrong now - dragging out new one, ->Javascript, >blocks works as expected as far as i can tell

definitely get rid of the question mark, it looks like an error. in that case i would just kill the box entirely

updated build with ? gone https://arcade.makecode.com/app/22da4e61e20a5638c912ce77ef8ebf35927c1a01-2648df1f02#pub:S43701-26279-46872-67107

okay moved off mutations for both bits it was using them for, storing the color for render & draggability. new build https://arcade.makecode.com/app/58da9454a6fad8f454b2a28a2d628e245aab3911-f90c86d399#pub:S43701-26279-46872-67107

1. Create theme variable and assign it the hex value in the color picker of the set simulator block

2. Switch to Javascript and then back to Blocks. Note that the color of the hex value bubble is now brown

Not blocking, but odd.

1. Create theme variable and assign it the hex value in the color picker of the set simulator block

2. Switch to Javascript and then back to Blocks. Note that the color of the hex value bubble is now brown Not blocking, but odd.

this ones from the default block behavior implemented for the colors -- without context of block it's "nested" in, can only fall back to the base for the color block (which is special cased since it needs the special behavior of swapping between hex / rgb / etc). Don't think a reasonable way to fix it really unless richard has some magic in mind

okay chatted with richard, and replaced the color mutation (that i mistakenly removed thinking goal was just removing mutations overall) which fixed the variable case you mentioned hassan & greatly simplified diff on draggable params (to basically just special casing the color blocks as a whole / not trying to do the sometimes draggable only if specific shadow block is set). Double checking now that i rolled all those back properly / none stuck around.

build https://arcade.makecode.com/app/2e6a1345f258e65440f04f87564b5ee0e8aee93e-5f6823ed88